Port System.Text.Json source comments to Docs (second attempt) #2471
Conversation
…ith most up-to-date APIs.
|
Adding area owners @ahsonkhan, @steveharter for review. @mairaw @rpetrusha for language review. Please take a look whenever you get a chance. I added some logic to the porting tool so it could automatically resolve the spacing issues we had last time. Let me know if you still see some inconsistencies. |
mairaw
added
new-content
There was a problem hiding this comment.
I've left two comments, @carlossanlop -- I don't think that the remarks for the two dispose methods are accurate. I've also incorporated all of my edits into your json branch, so it would be a good idea to review my two commits.
|
@rpetrusha I reviewed your two commits, thanks for doing those changes. Can we incorporate the contents of your review #2422 into this one? I think my tool did not catch those modifications in this PR, but the easiest thing to do is to merge it all at once here. I'll let you decide, let me know and I'll submit the modification. Edit: Nevermind, I see you already merged it. |
|
@rpetrusha This one's ready. Ahson confirmed the remarks are correct. |
|
Thanks, @carlossanlop. I'll merge now. |
Automatically port triple slash comments found in System.Text.Json to dotnet-api-docs.
Second attempt - The first PR got in a bad state (unresolvable conflicts) because several APIs in this namespace got changed. This PR now contains the most up-to-date API versions.